Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: WC - One step chain switch on chain mismatch #12810

Open
christopherferreira9 opened this issue Dec 20, 2024 · 0 comments
Open

[Bug]: WC - One step chain switch on chain mismatch #12810

christopherferreira9 opened this issue Dec 20, 2024 · 0 comments
Labels
regression-prod-7.36.0 Regression bug that was found in production in release 7.36.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-sdk SDK team type-bug Something isn't working

Comments

@christopherferreira9
Copy link
Contributor

christopherferreira9 commented Dec 20, 2024

Describe the bug

Ever since 7.36.0 a regression was added when the chain is on a different chain than the wallet is.
With the se-sdk (WC sdk we currently use), chainSwitching should happen when:

  • switching to a chain that hasn't been permitted before
  • upon request after mismatch (or auto switched with the new multichain feature [currently not available with WC])

Expected behavior

When the chain is mismatched, making a sign request should:

  1. ask the user to switch (or auto-switch after migration)
  2. prompt the user with the sign request

All this should happen in a one trip dapp <> wallet. It is currently requiring another jump between dapp and wallet to retry the signing after chain switch

Screenshots/Recordings

Screen.Recording.2024-12-20.at.2.26.42.PM.mov

Steps to reproduce

  1. Set MetaMask to mainnet
  2. Go to this dapp and set mainnet as the active chain
  3. Connect to the dapp
    3.1) via QR Code
    3.2) via deeplink
  4. Switch chain on the dapp to OP Mainnet -> a switch request should be prompt in MetaMask
  5. Accept the chain switch
  6. Switch chain to ethereum mainnet -> a switch request should be prompt in MetaMask
  7. Switch chain on the dapp to OP Mainnet -> At this point it is expected that the dapp has OP Mainnet as the active chain and MetaMask is still on ethereum mainnet
  8. Tap Sign
    8.1) On desktop <> mobile this should ask the user to switch chains to OP Mainnet + prompt the user with a signing request
    8.2) On mobile <> mobile this should redirect to MetaMask and ask the user to switch chains to OP Mainnet + prompt the user with a signing request in one go

Error messages or log output

Detection stage

In production (default)

Version

7.36.0

Build type

None

Device

iPhone 11

Operating system

iOS, Android

Additional context

No response

Severity

No response

@christopherferreira9 christopherferreira9 added the type-bug Something isn't working label Dec 20, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 20, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 20, 2024
@metamaskbot metamaskbot added the regression-prod-7.36.0 Regression bug that was found in production in release 7.36.0 label Dec 20, 2024
@smilingkylan smilingkylan added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.36.0 Regression bug that was found in production in release 7.36.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-sdk SDK team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants