Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] TypeError: undefined is not an object (evaluating 'n.flatMap') #12289

Open
sentry-io bot opened this issue Nov 14, 2024 · 10 comments · May be fixed by #13598
Open

[Sentry] TypeError: undefined is not an object (evaluating 'n.flatMap') #12289

sentry-io bot opened this issue Nov 14, 2024 · 10 comments · May be fixed by #13598
Assignees
Labels
area-Sentry Issue from Sentry regression-prod-7.34.0 Regression bug that was found in production in release 7.34.0 regression-prod-7.34.1 Regression bug that was found in production in release 7.34.1 regression-prod-7.35.0 Regression bug that was found in production in release 7.35.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-accounts type-bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Nov 14, 2024

Sentry Issue: METAMASK-MOBILE-31ZW

TypeError: undefined is not an object (evaluating 'n.flatMap')
  at None (app:///main.jsbundle:4661:386)
  at E (app:///main.jsbundle:2878:564)
  at None (app:///main.jsbundle:2877:1041)
  at E (app:///main.jsbundle:2878:564)
  at None (app:///main.jsbundle:2877:1007)
...
(16 additional frame(s) were not displayed)
Copy link
Author

sentry-io bot commented Nov 14, 2024

Sentry Issue: METAMASK-MOBILE-320N

@smilingkylan smilingkylan added regression-prod-7.34.0 Regression bug that was found in production in release 7.34.0 type-bug Something isn't working team-mobile-platform Mobile Platform team labels Nov 14, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 14, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 14, 2024
@metamaskbot metamaskbot changed the title TypeError: undefined is not an object (evaluating 'n.flatMap') [Sentry] TypeError: undefined is not an object (evaluating 'n.flatMap') Nov 15, 2024
@metamaskbot metamaskbot added the area-Sentry Issue from Sentry label Nov 15, 2024
@smilingkylan smilingkylan added the regression-prod-7.34.1 Regression bug that was found in production in release 7.34.1 label Nov 20, 2024
Copy link
Author

sentry-io bot commented Nov 20, 2024

Sentry Issue: METAMASK-MOBILE-33JJ

@smilingkylan
Copy link
Contributor

Better Sentry stacktrace:
https://metamask.sentry.io/issues/6064227489

@smilingkylan smilingkylan added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing and removed regression-prod-7.34.1 Regression bug that was found in production in release 7.34.1 labels Nov 20, 2024
Copy link
Author

sentry-io bot commented Nov 21, 2024

Sentry Issue: METAMASK-MOBILE-349E

@metamaskbot metamaskbot added regression-prod-7.35.0 Regression bug that was found in production in release 7.35.0 regression-prod-7.34.1 Regression bug that was found in production in release 7.34.1 and removed regression-prod-7.35.0 Regression bug that was found in production in release 7.35.0 labels Nov 22, 2024
@gauthierpetetin
Copy link
Contributor

gauthierpetetin commented Jan 21, 2025

Comment from @Cal-L during today's technical refinement session:

  • flatMap issue still exists so let's keep that. Last seen on 7.37.1
    Area of impact - The selector selectFlattenedKeyringAccounts has undefined keyrings value. Recommend to triage to Accounts team

@gauthierpetetin
Copy link
Contributor

Re-assigning this to the @MetaMask/account-management team

@gauthierpetetin gauthierpetetin added team-accounts and removed team-mobile-platform Mobile Platform team labels Jan 21, 2025
Copy link
Author

sentry-io bot commented Feb 18, 2025

Sentry Issue: METAMASK-MOBILE-37H4

@Gudahtt
Copy link
Member

Gudahtt commented Feb 18, 2025

This seems like another "render before initialization" issue, cc @Cal-L

Post-initialization, the keyrings state property is always an array. Even when locked, it's an empty array, never undefined.

@Gudahtt
Copy link
Member

Gudahtt commented Feb 18, 2025

Ah, after looking further at the stack trace, it might not be a "render" issue after all. getTraceTags is called before initialization as well, which uses selectors but isn't render-related.

@Gudahtt
Copy link
Member

Gudahtt commented Feb 19, 2025

From reviewing the linked Sentry issues, there are 2 older ones with minified stack traces that haven't recurred since v7.34.0. The others are all from getTraceTags. #13598 should resolve the problem.

This may not be a Sev1 either, but the impact isn't entirely clear to me. We'll close it soon either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry Issue from Sentry regression-prod-7.34.0 Regression bug that was found in production in release 7.34.0 regression-prod-7.34.1 Regression bug that was found in production in release 7.34.1 regression-prod-7.35.0 Regression bug that was found in production in release 7.35.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-accounts type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

5 participants