Skip to content

Commit

Permalink
feat: upgrade react-native-webview (#7759)
Browse files Browse the repository at this point in the history
## **Description**

Moving away from `.patch` changes on the webview

Our [RNWebView
fork](https://github.com/MetaMask/react-native-webview-mm) contains the
security patches.
The "Javascript Injection" patch was removed and the related patches to
fix bugs introduced by that.

Jest snapshots updates to reflect the new RNWebView component

## **Related issues**
[mobile-planning
#1294](https://github.com/MetaMask/mobile-planning/issues/1294)

## Acceptance Criteria
- [x] https://github.com/MetaMask/mobile-planning/issues/1618 ~must be
closed with zero bugs~ Done

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: tommasini <[email protected]>
Co-authored-by: sethkfman <[email protected]>
Co-authored-by: Curtis David <[email protected]>
Co-authored-by: legobt <[email protected]>
Co-authored-by: legobeat <[email protected]>
Co-authored-by: jiexi <[email protected]>
  • Loading branch information
7 people authored Jul 2, 2024
1 parent 3046046 commit 67eb692
Show file tree
Hide file tree
Showing 36 changed files with 4,860 additions and 1,691 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
TouchableOpacity,
View,
} from 'react-native';
import { WebView } from 'react-native-webview';
import { WebView } from '@metamask/react-native-webview';

// External dependencies.
import ButtonPrimary from '../../Buttons/Button/variants/ButtonPrimary';
Expand Down
Loading

0 comments on commit 67eb692

Please sign in to comment.