Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the experimental toggle for Solana #28190

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 30, 2024

Description

This PR sdds a new experimental toggle for Solana accounts. Everything is code fenced for Flask build.

Screenshot 2024-10-31 at 11 50 38

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-sol PRs from the Solana snap team label Oct 30, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-mmi PRs from the MMI team label Oct 30, 2024
@zone-live zone-live removed the team-mmi PRs from the MMI team label Oct 30, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8492b1e]
Page Load Metrics (2145 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38628402058482231
domContentLoaded170627912108291140
load177728402145294141
domInteractive1891482010
backgroundConnect772342512
firstReactRender521731092914
getState769302412
initialActions01000
loadScripts125321971583253122
setupStore1391282412
uiStartup198031492381321154
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 47 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 575 Bytes (0.01%)

@zone-live zone-live marked this pull request as ready for review October 31, 2024 09:47
@zone-live zone-live requested a review from a team as a code owner October 31, 2024 09:47
@metamaskbot
Copy link
Collaborator

Builds ready [f1feedf]
Page Load Metrics (3656 ± 723 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint392552426611728830
domContentLoaded1678559336071504722
load1688562936561506723
domInteractive293071258641
backgroundConnect10190634421
firstReactRender484051799445
getState598352713
initialActions01000
loadScripts1238425427301147551
setupStore1598452311
uiStartup1975687341071672803
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 47 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 498 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [1c9a455]
Page Load Metrics (1980 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30922451913390187
domContentLoaded17442172194813364
load17492236198013967
domInteractive14103542412
backgroundConnect884312311
firstReactRender581851072512
getState561222110
initialActions01000
loadScripts12551653144111354
setupStore1281362713
uiStartup19772462223013364
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 47 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 442 Bytes (0.01%)

@zone-live zone-live added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 08d1854 Nov 4, 2024
76 checks passed
@zone-live zone-live deleted the SOL-8-solana-experimental-setting branch November 4, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants