fix: Updates to the simulations component #28107

pedronfigueiredo · 2024-10-25T14:01:11Z

Description

Updates the copy, layout and text color for 3 scenarios: No changes, Generic Error and Fiat value not available as per design review.

Related issues

Fixes: #27072

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-25T14:01:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-10-28T12:13:52Z

Builds ready [78b91e9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2012 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	493	2307	1914	368	177
		domContentLoaded	1671	2550	1977	214	103
		load	1685	2587	2012	209	100
		domInteractive	16	64	41	15	7
		backgroundConnect	10	72	36	18	9
		firstReactRender	48	198	99	36	17
		getState	5	71	27	26	12
		initialActions	0	0	0	0	0
		loadScripts	1204	1911	1452	170	82
		setupStore	12	69	32	22	10
		uiStartup	1882	2892	2240	229	110

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1.92 KiB (0.03%)
common: -187 Bytes (-0.00%)

digiwand

In the GH description screenshots, "No Changes" is a lighter gray. Should we update the description and/or the UI? the Figma displays the copy with a darker gray

metamaskbot · 2024-10-30T15:39:02Z

Builds ready [496075b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1943 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	325	2240	1853	369	177
		domContentLoaded	1712	2214	1898	106	51
		load	1723	2229	1943	118	56
		domInteractive	17	80	42	18	9
		backgroundConnect	10	181	41	41	20
		firstReactRender	56	202	105	32	15
		getState	5	59	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1213	1594	1395	92	44
		setupStore	13	96	35	27	13
		uiStartup	1932	2586	2167	143	69

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1.92 KiB (0.03%)
common: -187 Bytes (-0.00%)

metamaskbot · 2024-10-30T18:47:05Z

Builds ready [30c9688]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2102 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	290	2799	2035	457	220
		domContentLoaded	1774	2784	2061	233	112
		load	1778	2800	2102	234	112
		domInteractive	20	186	62	34	16
		backgroundConnect	7	109	39	31	15
		firstReactRender	53	295	115	47	23
		getState	4	91	24	25	12
		initialActions	0	1	0	0	0
		loadScripts	1294	2237	1552	214	103
		setupStore	11	70	30	22	11
		uiStartup	2010	3072	2365	298	143

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1.92 KiB (0.02%)
common: -187 Bytes (-0.00%)

matthewwalsh0 · 2024-11-01T21:02:46Z

ui/pages/confirmations/components/confirm/info/personal-sign/personal-sign.tsx

+              alignItems={AlignItems.center}
+              justifyContent={JustifyContent.spaceBetween}
+            >
+              <Box


Minor, since we have three nested boxes, would the readability benefit from some local components?

matthewwalsh0 · 2024-11-01T21:03:37Z

ui/pages/confirmations/components/confirm/info/personal-sign/personal-sign.tsx

-          <ConfirmInfoRow
-            label={t('simulationDetailsTitle')}
-            tooltip={t('simulationDetailsTitleTooltip')}
+          <Box


I assume the necessary formatting isn't feasible to encapsulate within the ConfirmInfoRow component?

metamaskbot · 2024-11-05T11:59:50Z

Builds ready [5e521b0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1875 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	212	2317	1699	513	246
		domContentLoaded	1534	2304	1843	191	92
		load	1542	2316	1875	200	96
		domInteractive	17	84	42	16	8
		backgroundConnect	6	121	31	32	15
		firstReactRender	48	278	104	50	24
		getState	4	181	30	40	19
		initialActions	0	1	0	0	0
		loadScripts	1073	1681	1338	158	76
		setupStore	11	73	28	22	11
		uiStartup	1746	2661	2116	242	116

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1.92 KiB (0.02%)
common: -187 Bytes (-0.00%)

metamaskbot · 2024-11-06T11:44:58Z

Builds ready [aa22ec9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1824 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	372	1996	1627	428	206
		domContentLoaded	1549	2626	1804	226	109
		load	1557	2634	1824	226	108
		domInteractive	17	73	38	17	8
		backgroundConnect	8	53	23	14	7
		firstReactRender	47	123	94	22	11
		getState	4	51	11	12	6
		initialActions	0	1	0	0	0
		loadScripts	1131	1973	1333	183	88
		setupStore	10	93	34	28	13
		uiStartup	1757	2911	2047	247	118

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1.93 KiB (0.03%)
common: -187 Bytes (-0.00%)

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 25, 2024

pedronfigueiredo self-assigned this Oct 25, 2024

pedronfigueiredo requested review from a team as code owners October 25, 2024 14:01

jpuri previously approved these changes Oct 25, 2024

View reviewed changes

pedronfigueiredo dismissed jpuri’s stale review via f211561 October 25, 2024 14:26

pedronfigueiredo force-pushed the pnf/27072 branch 4 times, most recently from ab94ca6 to 78b91e9 Compare October 28, 2024 11:36

pedronfigueiredo enabled auto-merge October 28, 2024 14:38

digiwand requested changes Oct 29, 2024

View reviewed changes

pedronfigueiredo force-pushed the pnf/27072 branch from 78b91e9 to 496075b Compare October 30, 2024 14:59

pedronfigueiredo force-pushed the pnf/27072 branch 3 times, most recently from c6e0cee to 30c9688 Compare October 30, 2024 18:05

matthewwalsh0 previously approved these changes Nov 1, 2024

View reviewed changes

pedronfigueiredo dismissed matthewwalsh0’s stale review via 5e521b0 November 5, 2024 11:25

pedronfigueiredo force-pushed the pnf/27072 branch from 30c9688 to 5e521b0 Compare November 5, 2024 11:25

fix: Updates to the simulations component

aa22ec9

pedronfigueiredo force-pushed the pnf/27072 branch from 5e521b0 to aa22ec9 Compare November 6, 2024 11:08

pedronfigueiredo requested review from digiwand, jpuri and matthewwalsh0 November 6, 2024 11:09

digiwand approved these changes Nov 6, 2024

View reviewed changes

OGPoyraz approved these changes Nov 7, 2024

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Nov 7, 2024

Merged via the queue into develop with commit 3401ef0 Nov 7, 2024
76 checks passed

pedronfigueiredo deleted the pnf/27072 branch November 7, 2024 12:45

github-actions bot locked and limited conversation to collaborators Nov 7, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Updates to the simulations component #28107

fix: Updates to the simulations component #28107

pedronfigueiredo commented Oct 25, 2024 •

edited

Loading

github-actions bot commented Oct 25, 2024

metamaskbot commented Oct 28, 2024

digiwand left a comment

metamaskbot commented Oct 30, 2024

metamaskbot commented Oct 30, 2024

matthewwalsh0 Nov 1, 2024

matthewwalsh0 Nov 1, 2024

metamaskbot commented Nov 5, 2024

metamaskbot commented Nov 6, 2024

fix: Updates to the simulations component #28107

fix: Updates to the simulations component #28107

Conversation

pedronfigueiredo commented Oct 25, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 25, 2024

metamaskbot commented Oct 28, 2024

digiwand left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 30, 2024

metamaskbot commented Oct 30, 2024

matthewwalsh0 Nov 1, 2024

Choose a reason for hiding this comment

matthewwalsh0 Nov 1, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 5, 2024

metamaskbot commented Nov 6, 2024

pedronfigueiredo commented Oct 25, 2024 •

edited

Loading