Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prefer token symbol to token name #27693

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: Prefer token symbol to token name #27693

merged 1 commit into from
Oct 9, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Oct 8, 2024

Description

The petnames component defaults to show the name of the token instead of the symbol. Adding preferContractSymbol to the component overrides it to show the token symbol instead, for brevity.

The PR adds the prop to petnames components inside tx simulations and the address row component.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3371

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 8, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Oct 8, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners October 8, 2024 12:02
Copy link
Contributor

github-actions bot commented Oct 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Oct 8, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [68974d9]
Page Load Metrics (1807 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30522021661390187
domContentLoaded15532179177815977
load15622199180716680
domInteractive1998522311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 192 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 583d400 Oct 9, 2024
85 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3371 branch October 9, 2024 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 9, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants