Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no connected state for permissions page #27660

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

This PR is to add padding to the permissions page when no site or snap is connected

Related issues

Fixes:

Manual testing steps

  1. Go to All permissions page
  2. Disconnect all sites and snaps
  3. Check the copy is center aligned when not connected

Screenshots/Recordings

Before

Screenshot 2024-10-07 at 2 02 28 PM

After

Screenshot 2024-10-07 at 2 02 10 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner October 7, 2024 13:02
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ca4fb3e]
Page Load Metrics (1955 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint162326301944281135
domContentLoaded160826181914277133
load162526941955282135
domInteractive1780472210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 10 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [75fed70]
Page Load Metrics (2044 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25124501772632303
domContentLoaded17132333201514871
load17562415204415574
domInteractive27239534421
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 10 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha changed the title fixed no connected state for permissions page fix: no connected state for permissions page Oct 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [48ffeba]
Page Load Metrics (1784 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30926211721397190
domContentLoaded14962368175319192
load150525381784217104
domInteractive148345189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 10 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [702dd58]
Page Load Metrics (1945 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16212210193816780
domContentLoaded16142164190415976
load16212214194516378
domInteractive188845168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 10 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit d9d6fab Oct 14, 2024
78 checks passed
@NidhiKJha NidhiKJha deleted the fix-no-permission-state branch October 14, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 14, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants