fix: Consistent confirmation navigation #27326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
previously approved these changes
Sep 23, 2024
matthewwalsh0
requested changes
Sep 23, 2024
| @@ -28,15 +28,9 @@ export function pendingConfirmationsSortedSelector( | |||
| .sort((a1, a2) => a1.time - a2.time); | |||
| } | |||
|
|
|||
| const internalLatestPendingConfirmationSelector = createSelector( | |||
| export const oldestPendingConfirmationSelector = createSelector( | |||
There was a problem hiding this comment.
Do we definitely want to remove the createDeepEqualSelector here?
The recent Redux state PR should only update pendingApprovals when it actually changes, but if it does, then we'll get a fresh object reference and re-fire here unnecessarily?
These selectors are critical since they can impact everything using useConfirmContext.
pedronfigueiredo
force-pushed
the
pnf/27252
branch
from
8586fa8 to
0a6a568
Compare
Builds ready [0a6a568]
Page Load Metrics (1753 ± 67 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
jpuri
previously approved these changes
Sep 24, 2024
matthewwalsh0
requested changes
Sep 24, 2024
| @@ -21,22 +20,16 @@ export function pendingConfirmationsSelector(state: ConfirmMetamaskState) { | |||
| export function pendingConfirmationsSortedSelector( | |||
| state: ConfirmMetamaskState, | |||
| ) { | |||
| return getPendingApprovals(state) | |||
| return Object.values(state.metamask.pendingApprovals ?? {}) | |||
There was a problem hiding this comment.
There's no value in doing this yet as we're not using createSelector so we'll always generate a new reference anyway, but at least we can re-use getPendingApprovals.
pedronfigueiredo
force-pushed
the
pnf/27252
branch
from
74d514e to
8e9da4f
Compare
matthewwalsh0
approved these changes
Sep 24, 2024
jpuri
approved these changes
Sep 24, 2024
|
metamaskbot
added
the
release-12.6.0
Builds ready [8e9da4f]
Page Load Metrics (1945 ± 120 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
metamaskbot
added
the
release-12.5.0
metamaskbot
removed
the
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the way the old confirmation navigation works, when submitting multiple confirmation requests to the wallet, we want to select the oldest confirmation by default (1 of X).
If
paramsTransactionIdis undefined inui/pages/confirmations/hooks/syncConfirmPath.ts, the default confirmation id comes fromcurrentConfirmation. As such, the firstcurrentConfirmationselected inuseCurrentConfirmationwill determine the default position in the array of X sorted confirmations.Instead of using latestPendingApproval, we want to use the oldest (first to be created) one.
Related issues
Fixes: #27252
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist