refactor: replace Typography with Text component in gas-timing.component.js #27053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
force-pushed
the
devin/typography-xyz
branch
from
f928a35 to
1b1e99e
Compare
Comment on lines
-1
to
-12
| .typography.gas-timing { | ||
| color: var(--color-text-alternative); | ||
|
|
||
| .info-tooltip { | ||
| display: inline-block; | ||
| margin-inline-start: 4px; | ||
|
|
||
| path { | ||
| fill: var(--color-error-default); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is unused CSS and targeted the Typography component and InfoTooltip it shouldn't use component classes and InfoTooltip is no longer used in this file
Comment on lines
+50
to
+59
| export const GasTooLowStory: Story = { | ||
| args: { | ||
| maxFeePerGas: '1', // Simulate low gas fee | ||
| maxPriorityFeePerGas: '1', // Simulate low priority fee | ||
| gasWarnings: { | ||
| maxPriorityFee: GAS_FORM_ERRORS.MAX_PRIORITY_FEE_TOO_LOW, | ||
| maxFee: GAS_FORM_ERRORS.MAX_FEE_TOO_LOW, | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Adding new story to display replacement Text component
Before
After
| @@ -26,7 +26,6 @@ | |||
| @import 'edit-gas-fee-popover/edit-gas-tooltip/index'; | |||
| @import 'edit-gas-popover/index'; | |||
| @import 'gas-details-item/index'; | |||
| @import 'gas-timing/index'; | |||
There was a problem hiding this comment.
Removing deleted stylesheet from confirmations style index
| fontWeight={FontWeight.Bold} | ||
| color={TextColor.textAlternative} |
There was a problem hiding this comment.
Instead of changing color via the CSS we are doing using the style utility props
georgewrmarshall
added
team-design-system
Comment on lines
+37
to
+38
| maxFeePerGas: '0', | ||
| maxPriorityFeePerGas: '0', |
| @@ -4,6 +4,7 @@ import { Provider } from 'react-redux'; | |||
| import configureStore from '../../../../store/store'; | |||
| import GasTiming from './gas-timing.component'; | |||
| import mockState from '../../../../../test/data/mock-state.json'; | |||
| import { GAS_FORM_ERRORS } from '../../../../helpers/constants/gas'; | |||
There was a problem hiding this comment.
Used in new GasTooLowStory
Builds ready [8495d1e]
Page Load Metrics (1830 ± 76 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27053 +/- ##
===========================================
- Coverage 70.15% 70.11% -0.05%
===========================================
Files 1425 1426 +1
Lines 49653 49689 +36
Branches 13891 13902 +11
===========================================
+ Hits 34833 34835 +2
- Misses 14820 14854 +34 ☔ View full report in Codecov by Sentry. |
|
garrettbear
approved these changes
Sep 19, 2024
Builds ready [4aa198b]
Page Load Metrics (2045 ± 79 ms)
Bundle size diffs
|
jpuri
approved these changes
Sep 23, 2024
|
Builds ready [6bc33be]
Page Load Metrics (1919 ± 132 ms)
Bundle size diffs
|
|
OK to merge without SonarCloud Code Analysis |
metamaskbot
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the
Typographycomponent with the newTextcomponent in the fileui/pages/confirmations/components/gas-timing/gas-timing.component.js. This change is part of the ongoing effort to migrate from the oldTypographycomponent to the newTextcomponent across the MetaMask extension codebase.The main improvements in this change are:
TextcomponentDevin Run Link: https://preview.devin.ai/devin/d0382f35dd004ffba790f08bbd5ffc9c
Related issues
Partially Fixes: #17670
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
If you have any feedback, you can leave comments in the PR and I'll address them in the app!