Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS resolving for IPNS names #9037

Closed
decanus opened this issue Jul 20, 2020 · 0 comments · Fixed by #9051
Closed

ENS resolving for IPNS names #9037

decanus opened this issue Jul 20, 2020 · 0 comments · Fixed by #9051

Comments

@decanus
Copy link

decanus commented Jul 20, 2020

Bug Report

I already mentioned this to @rekmarks, but opening an issue too. The ENS resolving needs to be updated, this is due to a resolving bug in ENS that was probably carried over. If you use for example pactxt.eth in the browser it resolves. However uniswap.eth does not.

Problem

This is because there was an issue in the contenthash library that did not resolve names correctly when they were IPNS hashes. You can see a more detailed discussion here: ensdomains/ens-app#849. This was recently fixed in ENS which can be viewed here: ensdomains/ui#77.

Expected behavior

Names using IPNS names resolve properly in the browser.

Actual behavior

They currently do not.

Notes

A corresponding issue was opened in status: status-im/status-mobile#10974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant