Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom name to private networks/custom RPCs #5630

Closed
wbt opened this issue Oct 29, 2018 · 5 comments
Closed

Add custom name to private networks/custom RPCs #5630

wbt opened this issue Oct 29, 2018 · 5 comments

Comments

@wbt
Copy link
Contributor

wbt commented Oct 29, 2018

What problem are you trying to solve?
I'm frequently changing between private networks and want to see at a glance which network I'm on, ideally with some human-readable name, instead of just "Private Network:"
image
Why should only large public testnets be nameable?

Describe the solution you'd like
I'd like the ability to assign a custom name to RPCs, similar to how I can assign a custom name to an account number.
Also, in the popup where I'm asked to approve a transaction being sent, I'd like to be able to see which network I'm on when sending the transaction. In the upper right, there's a box containing a question mark in a circle with the words "Custom RPC" but clicking on that circle (or anywhere else in that box) does nothing, nor does hovering over it show a tooltip with the URL.

image

I would like for the box to say "Development Server" or "Test Server" or whatever other name I want to affiliate with the RPC URL, and on hover see a tooltip that shows me it's using RPC https://12.34.56.78:9001 or something like that.

@wbt
Copy link
Contributor Author

wbt commented Oct 29, 2018

An implementation of the UI from @bdresser's September 12 comment on issue #5134 would likely address at least part of this Issue; there may be some residual parts regarding the tooltip on hover to show the URL. It looks like there's progress being made there; thanks!

@wbt
Copy link
Contributor Author

wbt commented Nov 5, 2018

This appears fixed in version 4.17.1, likely in PR 5134.

@wbt wbt closed this as completed Nov 5, 2018
@filips123
Copy link
Contributor

Pull request #5134 only adds chainId field, but network will still be displayed as URL in menu. Is it possible to change it?

@wbt
Copy link
Contributor Author

wbt commented Dec 26, 2018

@filips123 What version are you using? When I set a custom name for the network (see field in this screenshot or later ones) that custom name shows up in the upper right and in the drop-down that appears when I click on the network selector.

@filips123
Copy link
Contributor

@wbt It is OK! I change wrong field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants