Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Hide ethereum USD value for custom RPC #5327

Closed
ghost opened this issue Sep 23, 2018 · 4 comments
Closed

Bug: Hide ethereum USD value for custom RPC #5327

ghost opened this issue Sep 23, 2018 · 4 comments
Labels
area-UI Relating to the user interface.

Comments

@ghost
Copy link

ghost commented Sep 23, 2018

No description provided.

@ghost ghost changed the title Bug: Hide ethereum usd value for custom RPC Bug: Hide ethereum USD value for custom RPC Sep 25, 2018
@bdresser
Copy link
Contributor

@eosclassicteam expected behavior in #5134 is to lookup the asset on the balanc3 API, then look up on the cryptocompare API (or CMC as per your last comment), then if nothing is found simply don't show a conversion. That sound reasonable?

@ghost
Copy link
Author

ghost commented Sep 27, 2018

@bdresser Not for #5134 , but also for test networks like ropsten or rinkeby

testcoin

Some people think they are spending real ETH on test networks due to this fiat value conversion for testnet coins

@hackmod
Copy link
Contributor

hackmod commented Sep 29, 2018 •
edited
Loading

@bdresser

expected behavior in #5134 is to lookup the asset on the balanc3 API, then look up on the cryptocompare API (or CMC as per your last comment), then if nothing is found simply don't show a conversion. That sound reasonable?

that was a bug in PR #5134 and fixed for customRpc now.

@bdresser bdresser added the area-UI Relating to the user interface. label Dec 6, 2018
@bdresser bdresser mentioned this issue Jan 22, 2019
Closed
@bdresser bdresser mentioned this issue Jan 31, 2019
Closed
@bdresser
Copy link
Contributor

this work is being tracked in #4775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-UI Relating to the user interface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdresser @hackmod