Address feedback

MetaMask · Sep 5, 2024 · 912ccef · 912ccef
1 parent ec9c7ad
commit 912ccef
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 28 deletions.
diff --git a/...s/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx b/...s/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx
@@ -65,7 +65,7 @@ export const ApproveStaticSimulation = () => {
     </Text>
   );
 
-  const simulationElements = (
+  const SpendingCapRow = (
     <ConfirmInfoRow
       label={isNFT ? t('simulationApproveHeading') : t('spendingCap')}
     >
@@ -93,6 +93,8 @@ export const ApproveStaticSimulation = () => {
     </ConfirmInfoRow>
   );
 
+  const simulationElements = SpendingCapRow;
+
   return (
     <StaticSimulation
       title={t('simulationDetailsTitle')}

diff --git a/ui/pages/confirmations/components/confirm/info/approve/hooks/use-custom-spending-cap.ts b/ui/pages/confirmations/components/confirm/info/approve/hooks/use-custom-spending-cap.ts
diff --git a/...ons/components/confirm/info/approve/revoke-static-simulation/revoke-static-simulation.tsx b/...ons/components/confirm/info/approve/revoke-static-simulation/revoke-static-simulation.tsx
@@ -16,29 +16,36 @@ export const RevokeStaticSimulation = () => {
     currentConfirmation: TransactionMeta;
   };
 
-  const simulationElements = (
-    <>
-      <ConfirmInfoRow label={t('spendingCap')}>
-        <Box style={{ marginLeft: 'auto', maxWidth: '100%' }}>
-          <Box display={Display.Flex}>
-            <Name
-              value={transactionMeta.txParams.to as string}
-              type={NameType.ETHEREUM_ADDRESS}
-            />
-          </Box>
+  const TokenContractRow = (
+    <ConfirmInfoRow label={t('spendingCap')}>
+      <Box style={{ marginLeft: 'auto', maxWidth: '100%' }}>
+        <Box display={Display.Flex}>
+          <Name
+            value={transactionMeta.txParams.to as string}
+            type={NameType.ETHEREUM_ADDRESS}
+          />
         </Box>
-      </ConfirmInfoRow>
+      </Box>
+    </ConfirmInfoRow>
+  );
 
-      <ConfirmInfoRow label={t('spender')}>
-        <Box style={{ marginLeft: 'auto', maxWidth: '100%' }}>
-          <Box display={Display.Flex}>
-            <Name
-              value={transactionMeta.txParams.from as string}
-              type={NameType.ETHEREUM_ADDRESS}
-            />
-          </Box>
+  const SpenderRow = (
+    <ConfirmInfoRow label={t('spender')}>
+      <Box style={{ marginLeft: 'auto', maxWidth: '100%' }}>
+        <Box display={Display.Flex}>
+          <Name
+            value={transactionMeta.txParams.from as string}
+            type={NameType.ETHEREUM_ADDRESS}
+          />
         </Box>
-      </ConfirmInfoRow>
+      </Box>
+    </ConfirmInfoRow>
+  );
+
+  const simulationElements = (
+    <>
+      {TokenContractRow}
+      {SpenderRow}
     </>
   );