fix: Prefer token symbol to token name

MetaMask · Oct 8, 2024 · 68974d9 · 68974d9
1 parent 8dedd3c
commit 68974d9
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 3 deletions.
diff --git a/ui/components/app/confirm/info/row/address.tsx b/ui/components/app/confirm/info/row/address.tsx
@@ -44,7 +44,11 @@ export const ConfirmInfoRowAddress = memo(
           // component can support variations. See this comment for context: //
           // https://github.com/MetaMask/metamask-extension/pull/23487#discussion_r1525055546
           isPetNamesEnabled && !isSnapUsingThis ? (
-            <Name value={hexAddress} type={NameType.ETHEREUM_ADDRESS} />
+            <Name
+              value={hexAddress}
+              type={NameType.ETHEREUM_ADDRESS}
+              preferContractSymbol
+            />
           ) : (
             <>
               <Box

diff --git a/...s/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx b/...s/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx
@@ -87,6 +87,7 @@ export const ApproveStaticSimulation = () => {
           <Name
             value={transactionMeta.txParams.to as string}
             type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
           />
         </Box>
       </Box>

diff --git a/...ons/components/confirm/info/approve/revoke-static-simulation/revoke-static-simulation.tsx b/...ons/components/confirm/info/approve/revoke-static-simulation/revoke-static-simulation.tsx
@@ -23,6 +23,7 @@ export const RevokeStaticSimulation = () => {
           <Name
             value={transactionMeta.txParams.to as string}
             type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
           />
         </Box>
       </Box>
@@ -36,6 +37,7 @@ export const RevokeStaticSimulation = () => {
           <Name
             value={transactionMeta.txParams.from as string}
             type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
           />
         </Box>
       </Box>

diff --git a/...-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx b/...-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx
@@ -29,6 +29,7 @@ export const RevokeSetApprovalForAllStaticSimulation = ({
           <Name
             value={transactionMeta.txParams.to as string}
             type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
           />
         </Box>
       </Box>
@@ -39,7 +40,11 @@ export const RevokeSetApprovalForAllStaticSimulation = ({
     <ConfirmInfoRow label={t('permissionFrom')}>
       <Box style={{ marginLeft: 'auto', maxWidth: '100%' }}>
         <Box display={Display.Flex} alignItems={AlignItems.center}>
-          <Name value={spender} type={NameType.ETHEREUM_ADDRESS} />
+          <Name
+            value={spender}
+            type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
+          />
         </Box>
       </Box>
     </ConfirmInfoRow>

diff --git a/...ll-info/set-approval-for-all-static-simulation/set-approval-for-all-static-simulation.tsx b/...ll-info/set-approval-for-all-static-simulation/set-approval-for-all-static-simulation.tsx
@@ -47,6 +47,7 @@ export const SetApprovalForAllStaticSimulation = () => {
           <Name
             value={transactionMeta.txParams.to as string}
             type={NameType.ETHEREUM_ADDRESS}
+            preferContractSymbol
           />
         </Box>
       </Box>

diff --git a/...ions/components/confirm/info/typed-sign/permit-simulation/value-display/value-display.tsx b/...ions/components/confirm/info/typed-sign/permit-simulation/value-display/value-display.tsx
@@ -116,7 +116,11 @@ const PermitSimulationValueDisplay: React.FC<
             </Text>
           </Tooltip>
         </Box>
-        <Name value={tokenContract} type={NameType.ETHEREUM_ADDRESS} />
+        <Name
+          value={tokenContract}
+          type={NameType.ETHEREUM_ADDRESS}
+          preferContractSymbol
+        />
       </Box>
       <Box>
         {fiatValue && <IndividualFiatDisplay fiatAmount={fiatValue} shorten />}
-Original file line number
+Diff line change
@@ Expand Up / @@ -87,6 +87,7 @@ export const ApproveStaticSimulation = () => { @@
               <Name
                 value={transactionMeta.txParams.to as string}
                 type={NameType.ETHEREUM_ADDRESS}
+                preferContractSymbol
               />
             </Box>
           </Box>
@@ Expand Down @@