From 12246e1b207e52fbd4797bdbe177732b1bf7b0da Mon Sep 17 00:00:00 2001 From: David Walsh Date: Thu, 14 Nov 2024 13:27:42 -0600 Subject: [PATCH] fix: Allow outerclick to close import modal (#28448) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Clicking outside of modals is generally an assumed "now close the modal" interaction. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28448?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Open the Import Tokens modal 2. Click the background 3. See the modal go away ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- .../multichain/import-tokens-modal/import-tokens-modal.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/components/multichain/import-tokens-modal/import-tokens-modal.js b/ui/components/multichain/import-tokens-modal/import-tokens-modal.js index 0123bc91b147..b9ef596b8f07 100644 --- a/ui/components/multichain/import-tokens-modal/import-tokens-modal.js +++ b/ui/components/multichain/import-tokens-modal/import-tokens-modal.js @@ -493,7 +493,6 @@ export const ImportTokensModal = ({ onClose }) => { return ( { dispatch(clearPendingTokens()); onClose();