Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Fix storybook PR builds #740

Closed
georgewrmarshall opened this issue Nov 5, 2024 · 0 comments
Closed

Fix storybook PR builds #740

georgewrmarshall opened this issue Nov 5, 2024 · 0 comments
Labels
team-design-system All issues relating to design system

Comments

@georgewrmarshall
Copy link
Collaborator

Description

The ci/circleci: job-announce-storybook job is currently failing due to an "Unauthorized" error when attempting to post comments via the metamaskbot. This issue prevents successful completion of the build announcement step in CircleCI and blocks merges without manual intervention.

Technical Details

  • The error occurs in the build:announce script, specifically in metamaskbot-build-announce.js, where a POST request to the GitHub API fails with an "Unauthorized" status.
  • This may be caused by an invalid or missing GitHub authentication token for the metamaskbot.
  • Possible areas for investigation:
    • Verify that the GITHUB_TOKEN or equivalent is correctly set up and passed to the job.
    • Confirm that the metamaskbot has the necessary permissions to post comments on issues and pull requests in this repository.
    • Update or refresh any stored authentication tokens if they are expired or revoked.

Acceptance Criteria

  • The ci/circleci: job-announce-storybook job completes successfully without authorization errors.
  • metamaskbot posts comments as expected on issues and pull requests.
  • CI/CD pipeline no longer blocks merges due to this error.

References

  • Screenshots of the error logs.
  • [CircleCI configuration file and metamaskbot-build-announce.js script](Link to specific config or script if applicable).
  • Related Slack threads or discussions (if available).
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Nov 5, 2024
This was referenced Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

No branches or pull requests

1 participant