-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
30.0.0 #848
30.0.0 #848
Conversation
The commits under "Uncategorized" have not been reviewed yet.
I have asked @Cal-L to provide summaries for the following changelog entries:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the notes here as compared to the changes made in the referenced PRs and had some suggestions on wording. A few things to keep in mind when writing release notes:
- Try to include context for people who might not understand the feature being added or change being made. The original commit message may not contain this context because of brevity but keep in mind you can feel free to explain more things here. People shouldn't have to click into the PR to get that context.
- Remember to include any changes to types as that is as much a part of the public API as method/function names.
- Remember to include which controller is being updated as part of your note. This will get better once we switch to a monorepo because we can keep separate changelogs per package but for now it's something you have to keep in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @adonesky1 |
* 30.0.0 Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Cal Leung <[email protected]>
* 30.0.0 Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Cal Leung <[email protected]>
This is the release candidate for version 30.0.0.
[30.0.0]
Added
getNetworkState
,getPreferencesState
, andonTokenListStateChange
to the TokenDetectionController constructor options object (#808)useTokenDetection
from the PreferencesController state.chainId
from the NetworkController state.chainId
to AssetsContractController and add check whether current network supports token detection (#809)onNetworkStateChange
inAssetsContractController
constructor options object. This method should be called with network/provider details when network changes occur.Changed
addTokens
toaddDetectedTokens
on the TokenDetectionController constructor (#808)useStaticTokenList
touseTokenDetection
on thePreferencesController
constructor options object and set the value to be true by default (#808)test
method onPhishingController
no longer returns a boolean, it now returns an object matching theEthPhishingDetectResult
interface (defined inPhishingController.ts
).convertPriceToDecimal
method name toconvertHexToDecimal
(#808)detectedTokens
to the config object to track detected tokens, which is updated by callingaddDetectedTokens
whenever TokenDetectionController detects new tokens.fetchTokenMetadata
private method to fetch token metadata whenever adding individual tokens. This is currently used to populate aggregator information.detectedTokens
to both TokenBalancesController & TokenRatesControllertokens
config object within theironTokensStateChange
listener methods (#808)Removed
removeAndIgnoreToken
method in TokensController (#808)ignoredTokens
. Consumers will need to update instances of removeAndIgnoreToken to use ignoredTokens instead.onTokensStateChange
from the TokenDetectionController constructor options object (#808)tokens
property in the controller's configuration object. This is not needed since those tokens are managed by the TokensController.useStaticTokenList
andonPreferencesStateChange
from TokenListController constructor options object (#806)Fixed
bytes32