Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ERC721 token URI parsing into try catch block #818

Closed
wants to merge 1 commit into from
Closed

Move ERC721 token URI parsing into try catch block #818

wants to merge 1 commit into from

Conversation

hashwarp
Copy link

@hashwarp hashwarp commented May 9, 2022

PR Title

Move ERC721 token URI parsing into try catch block

Description

Move ERC721 token URI parsing into try catch block. I included a test but can omit if deemed bloat.

  • FIXED:

    • Not all contract token URIs are valid/can be fetched, and we should have backwards compatibility because they usually cannot be redeployed

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves metamask-extension#14589

@hashwarp hashwarp requested a review from a team as a code owner May 9, 2022 01:31
@hashwarp
Copy link
Author

hashwarp commented May 9, 2022

Note: the code in the try/block was introduced on March 3rd and I think it was a simple oversight to not have wrapped the entirety of the new code (because none of these variables are required)

@mcmire
Copy link
Contributor

mcmire commented May 9, 2022

@adonesky1 What do you think about this?

@FrederikBolding
Copy link
Member

Closing as this was rectified in #834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ERC-721 approve calls loading infinitely
3 participants