Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency version eth-phishing-detect #742

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

409H
Copy link
Contributor

@409H 409H commented Mar 23, 2022

Bump dependency version eth-phishing-detect

  • Bumps dependency version of eth-phishing-detect to include logic to convert absolute fully qualified domain name to the fully qualified domain name

Description

  • BREAKING:

  • FIXED:

  • CHANGED:

    • Dependency version
  • REMOVED:

  • ADDED:

  • DEPRECATED:

  • SECURITY:

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@409H 409H requested a review from a team as a code owner March 23, 2022 00:06
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New change in 1.1.16 is MetaMask/eth-phishing-detect#6891, correct? If so looks good to me.

@409H
Copy link
Contributor Author

409H commented Mar 24, 2022

New change in 1.1.16 is MetaMask/eth-phishing-detect#6891, correct? If so looks good to me.

Yep, that's correct!

@Gudahtt Gudahtt merged commit df71440 into main Mar 24, 2022
@Gudahtt Gudahtt deleted the enhancement/bump-eth-phishing-detect branch March 24, 2022 23:13
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants