Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 180.0.0 #4548
Release 180.0.0 #4548
Changes from 26 commits
e7ede77
5359a60
a8c25d2
c35839c
7325e9a
a28f7ea
9b88eec
647fa4d
6c936cf
83060c1
41ba4e6
13781b2
2e13b78
2670df1
a41ab2a
7617a9c
f842953
d138870
a3308b8
ac917f0
61670f3
773baa3
9c6e404
2d70e2a
e05f50f
225ed0f
d19d49b
dd39bee
d7d7985
96f428e
4f6c79d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MetaMask/accounts-engineers Should any of these be peer dependencies (esp.
snaps-controllers
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically the snaps controller is added as a peer dependency, for the same reason as the other controllers. I don't see the others as being used as peer deps though.
Perhaps we can move the controller to be a peer dependency later, since it's a pre-existing issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we releasing this package? If not, should we add these changelog entries in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To include the changes in #4556, I added releases for:
ens-controller
(a3308b8)gas-fee-controller
(ac917f0)selected-network-controller
,queued-request-controller
61670f3transaction-controller
,user-operation-controller
773baa3Every package with a diff in this PR is now being released (excluding
json-rpc-engine
).