Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revoke method to allow invalidating own permissions #723

Closed
danfinlay opened this issue Mar 26, 2021 · 3 comments
Closed

Add revoke method to allow invalidating own permissions #723

danfinlay opened this issue Mar 26, 2021 · 3 comments
Labels
PermissionController Related to the PermissionController.

Comments

@danfinlay
Copy link
Contributor

Could allow connections to provide "log out" type experiences.
Could allow optional parameters for which permissions to revoke, otherwise could revoke all outstanding permissions.

@garmeeh
Copy link

garmeeh commented Nov 18, 2021

I think this would be a great addition. I understand it may not technically be needed.

However as we try to move dapps towards more traditional web users not having a "log out" like feature/feel could be a barrier to entry. New users to the space may feel uneasy seeing that their wallet can be easily "reconnected" even tho they may have "logged out". I have seen many dapps fake the log out experience which could damage the trust in MetaMask even tho it is not MetaMask fault.

@rekmarks rekmarks transferred this issue from MetaMask/rpc-cap Jan 3, 2022
@rekmarks rekmarks added the PermissionController Related to the PermissionController. label Jan 3, 2022
@BboyAkers
Copy link

BboyAkers commented Jan 6, 2022

Is it possible for MetaMask to throw an info box or warning stating "User Logged out" modal in the wallet UI? It could be a means of double assurance for the user. While it may show in the dapp's UI(which could be faked) The source of truth to look at would be the MM wallet. Very similar to how we disconnect and it shows that 'we're not connected to that site'. It could show a message stating 'you've been disconnected from this site: '. There could be a logout boolean endpoint that'll trigger the modal. I'm positive i'm over simplifying it 😅 . Just though I'd throw an idea out there.

Update:

Just realized this would be a perfect opportunity for snaps lol, hence it being under this repo 😅 😆 . I'm looking into creating a snaps plugin right now. Will update ya'll if I can build out a PoC for this.

@rekmarks rekmarks transferred this issue from MetaMask/snaps Mar 11, 2022
@rekmarks
Copy link
Member

rekmarks commented Apr 26, 2024

This has actually been completed since we added wallet_revokePermissions in #1889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PermissionController Related to the PermissionController.
Projects
None yet
Development

No branches or pull requests

4 participants