Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's now impossible to autofix new lint violations introduced on the current branch #5212

Open
mcmire opened this issue Jan 29, 2025 · 1 comment
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 29, 2025

yarn lint:fix is a handy way to automatically fix lint violations. However, with the upgrade to ESLint 9, this package script became useless, as it now fixes warnings and errors across the entire monorepo.

We could change this script to only autofix errors, but I don't think that addresses the real need here.

Acceptance Criteria

  • It is possible to only fix the lint errors and warnings introduced in a new branch and nothing more.
@mcmire
Copy link
Contributor Author

mcmire commented Jan 29, 2025

Maybe we could pull ideas from this repo in order to only lint files and lines that have changed in the current branch: https://github.com/paleite/eslint-plugin-diff

Also see this ticket for some ideas: #1333 as well as this branch: https://github.com/MetaMask/core/tree/use-lint-changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant