Query for name and symbol on ERC721 contracts regardless of whether o…

…r not they support the metadata interface (#834) * query for name and symbol on erc721 contracts regardless of whether or not they support the metadata interface
MetaMask · Oct 11, 2023 · 8921657 · 8921657
1 parent 7a24b8c
commit 8921657
Show file tree

Hide file tree

Showing 3 changed files with 140 additions and 134 deletions.
diff --git a/src/assets/Standards/CollectibleStandards/ERC1155/ERC1155Standard.ts b/src/assets/Standards/CollectibleStandards/ERC1155/ERC1155Standard.ts
@@ -188,6 +188,10 @@ export class ERC1155Standard {
     image: string | undefined;
   }> => {
     const isERC1155 = await this.contractSupportsBase1155Interface(address);
+
+    if (!isERC1155) {
+      throw new Error("This isn't a valid ERC1155 contract");
+    }
     let tokenURI, image;
 
     if (tokenId) {
@@ -209,14 +213,10 @@ export class ERC1155Standard {
     }
 
     // TODO consider querying to the metadata to get name.
-    if (isERC1155) {
-      return {
-        standard: ERC1155,
-        tokenURI,
-        image,
-      };
-    }
-
-    throw new Error("This isn't a valid ERC1155 contract");
+    return {
+      standard: ERC1155,
+      tokenURI,
+      image,
+    };
   };
 }