bump eth-keyring-controller to v7.0.2 #819
Merged
+10
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some changes needed in the KeyringController class as well, at least JSDoc updates. They still say a string is expected for the seed |
|
Any reason you decided to make that change in a separate PR? The change is happening here, due to the dependency update |
🤔 Good point... 😜 |
|
@Gudahtt Added the commit here. I think I got confused because I had formatted the PR description in a way that looked like a changelog update so my brain farted. |
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* bump eth-keyring-controller to v7.0.2 * update seed argument type for createNewVaultAndRestore to string or array of numbers
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* bump eth-keyring-controller to v7.0.2 * update seed argument type for createNewVaultAndRestore to string or array of numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGED:
eth-keyring-controllerto v7.0.2