Added revokePermissions to PermissionController actions #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
previously requested changes
Mar 4, 2022
There was a problem hiding this comment.
A few small comments.
Requested review from @rekmarks too since I want to make sure that it is fine to expose revokePermission. I assume so, but want to be sure.
hmalik88
reviewed
Mar 4, 2022
Co-authored-by: Hassan Malik <[email protected]>
hmalik88
previously approved these changes
Mar 4, 2022
rekmarks
reviewed
Mar 4, 2022
rekmarks
approved these changes
Mar 4, 2022
hmalik88
approved these changes
Mar 4, 2022
FrederikBolding
approved these changes
Mar 7, 2022
soralit
pushed a commit
to KeystoneHQ/controllers
that referenced
this pull request
Mar 14, 2022
* Added revokePermissions to PermissionController actions Co-authored-by: Hassan Malik <[email protected]> Co-authored-by: Erik Marks <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added revokePermissions to PermissionController actions Co-authored-by: Hassan Malik <[email protected]> Co-authored-by: Erik Marks <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added revokePermissions to PermissionController actions Co-authored-by: Hassan Malik <[email protected]> Co-authored-by: Erik Marks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.