Remove polling start call in detection controllers' constructors #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adonesky1
commented
Nov 5, 2021
adonesky1
commented
- BREAKING: Removes call to start polling from the constructors of CollectibleDetectionController and TokenDetectionController.
- Consumers of either of these Controllers who wish to immediately start polling upon instantiation will need to call the start method on the controller right after instantiating the controller.
adonesky1
force-pushed
the
remove-default-detection-start
branch
from
dc51b7e to
e333c86
Compare
adonesky1
force-pushed
the
remove-default-detection-start
branch
from
e333c86 to
4dccf5e
Compare
danjm
approved these changes
Nov 10, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove polling start call in detection controllers' constructors
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove polling start call in detection controllers' constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.