Added GrantPermissions action to PermissionsController (#780)

* Added GrantPermissions action to PermissionsController * Added test for PermissionController:grantPermissions action
MetaMask · Apr 13, 2022 · e4d59b6 · e4d59b6
1 parent e4925ee
commit e4d59b6
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/src/permissions/PermissionController.test.ts b/src/permissions/PermissionController.test.ts
@@ -30,7 +30,6 @@ import {
   RestrictedMethodParameters,
   ValidPermission,
 } from '.';
-
 // Caveat types and specifications
 
 const CaveatTypes = {
@@ -4492,6 +4491,27 @@ describe('PermissionController', () => {
       );
     });
 
+    it('action: PermissionsController:grantPermissions', async () => {
+      const messenger = getUnrestrictedMessenger();
+      const options = getPermissionControllerOptions({
+        messenger: getPermissionControllerMessenger(messenger),
+      });
+      const controller = new PermissionController<
+        DefaultPermissionSpecifications,
+        DefaultCaveatSpecifications
+      >(options);
+
+      const result = messenger.call('PermissionController:grantPermissions', {
+        subject: { origin: 'foo' },
+        approvedPermissions: { wallet_getSecretArray: {} },
+      });
+
+      expect(result).toHaveProperty('wallet_getSecretArray');
+      expect(
+        controller.hasPermission('foo', 'wallet_getSecretArray'),
+      ).toStrictEqual(true);
+    });
+
     it('action: PermissionsController:requestPermissions', async () => {
       const messenger = getUnrestrictedMessenger();
       const options = getPermissionControllerOptions({

diff --git a/src/permissions/PermissionController.ts b/src/permissions/PermissionController.ts
@@ -212,6 +212,14 @@ export type HasPermission = {
   handler: GenericPermissionController['hasPermission'];
 };
 
+/**
+ * Directly grants given permissions for a specificed origin without requesting user approval
+ */
+export type GrantPermissions = {
+  type: `${typeof controllerName}:grantPermissions`;
+  handler: GenericPermissionController['grantPermissions'];
+};
+
 /**
  * Requests given permissions for a specified origin
  */
@@ -272,6 +280,7 @@ export type PermissionControllerActions =
   | GetPermissions
   | HasPermission
   | HasPermissions
+  | GrantPermissions
   | RequestPermissions
   | RevokeAllPermissions
   | RevokePermissionForAllSubjects
@@ -690,6 +699,11 @@ export class PermissionController<
       (origin: OriginString) => this.hasPermissions(origin),
     );
 
+    this.messagingSystem.registerActionHandler(
+      `${controllerName}:grantPermissions` as const,
+      this.grantPermissions.bind(this),
+    );
+
     this.messagingSystem.registerActionHandler(
       `${controllerName}:requestPermissions` as const,
       (subject: PermissionSubjectMetadata, permissions: RequestedPermissions) =>