Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent addresses from being added to the URLs #90

Open
vandan opened this issue Dec 7, 2023 · 1 comment
Open

Prevent addresses from being added to the URLs #90

vandan opened this issue Dec 7, 2023 · 1 comment

Comments

@vandan
Copy link

vandan commented Dec 7, 2023

Though the playground isn't intended for use with sensitive information, we should still avoid including addresses in URLs to avoid any privacy risks.

The recent addition of analytics that are including URLs in the event parameters exacerbates this risk so it should be prioritized.

Here's an example of what's being passed when there are params included in the URL (there is some masking but that is from a third-party UI and doesn't mean they don't have the full address in their system):

analytics.page({
  path: '/wallet/reference/wallet_requestpermissions/',
  referrer: '',
  search: '?requestPermissionsObject[eth_accounts][account]=0***',
  title: 'MetaMask developer documentation',
  url: 'https://docs.metamask.io/wallet/reference/wallet_requestpermissions/?requestPermissionsObject[eth_accounts][account]=0***'
});

At the same time, we want to balance privacy against the developer experience.
@BelfordZ recommends adding a "Copy" button to allow developers to save their input data from the playground in case they need it again later.

@BelfordZ
Copy link
Contributor

BelfordZ commented Dec 7, 2023

just to clarify, the copy button would

  1. set the url params to include the request params
  2. copy the url into your clipboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants