Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: EveryCompat causing crash (related to moonlight) #703

Closed
4 tasks done
Gamemassa opened this issue Nov 29, 2024 · 23 comments
Closed
4 tasks done

[🐞]: EveryCompat causing crash (related to moonlight) #703

Gamemassa opened this issue Nov 29, 2024 · 23 comments
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working

Comments

@Gamemassa
Copy link

Gamemassa commented Nov 29, 2024

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader

1.21.1 - FABRIC

EveryCompat Version

everycompat-1.21-2.7.5

Moonlight Lib Version

moonlight-1.21-2.17.7

Issue with mods

Not sure.

Issue Detail

Seems like it's trying to load recipes/assets from mods I don't even have installed.

OPTIONAL: Latest.log | Crash-report Attachment

Crash Report:
https://mclo.gs/uxdOM3K

Latest.log
https://mclo.gs/7fveNHg

@Gamemassa Gamemassa added the bug Something isn't working label Nov 29, 2024
@github-actions github-actions bot added the 1.21.1-FABRIC Minecraft Version label Nov 29, 2024
@Xelbayria
Copy link
Collaborator

I believe the issue is in Moonlight Lib, it has some a few changes related to Recipes.

try downgrade to older version of Moonlight Lib.

@Gamemassa
Copy link
Author

Gamemassa commented Nov 30, 2024

I believe the issue is in Moonlight Lib, it has some a few changes related to Recipes.

try downgrade to older version of Moonlight Lib.

What version would you recommend? Edit: I tried a handful of different versions. It seems like Moonlight 2.14.X and 2.15.X versions cause crashes on startup, but 2.16.0 is working for now.

@Xelbayria
Copy link
Collaborator

The bugs in moonlight lib should be fixed. Try the latest version of Moonlight Lib.

@Xelbayria Xelbayria added the Moonlight Lib Cause is in Moonlight Lib label Dec 6, 2024
@Xelbayria Xelbayria changed the title [🐞]: EveryCompat causing crash: [🐞]: EveryCompat causing crash (related to moonlight) Dec 6, 2024
@Gamemassa
Copy link
Author

The bugs in moonlight lib should be fixed. Try the latest version of Moonlight Lib.

I don't think it's fixed:

Crash Report: https://mclo.gs/QFD6mtg

Latest.log: https://mclo.gs/T8tU8dH

@MehVahdJukaar
Copy link
Owner

your every compat is not updated

@Gamemassa
Copy link
Author

Gamemassa commented Dec 8, 2024

your every compat is not updated

With as much respect as possible (because I love your mod and you are a great developer) TF are you talking about?

image

image

@Poopooracoocoo
Copy link

Only on CurseForge for some reason: https://www.curseforge.com/minecraft/mc-mods/every-compat/files/5961351

@Gamemassa
Copy link
Author

Now I'm getting this crash on startup. Not sure if this is still the same thing or needs its own thread (I did also update Sawmill because that ended up needing to be updated):

Crash Report:
https://mclo.gs/XHxeo0A

Latest.log
https://mclo.gs/HAud6U4

@Xelbayria
Copy link
Collaborator

Has the Moonlight Lib v2.17.12 fix the problem?

@Gamemassa
Copy link
Author

Doesn't seem like it.

Crash Report:
https://mclo.gs/JOhZllB

Latest.log
https://mclo.gs/Zx6tS0v

@Gamemassa
Copy link
Author

Currently, EveryComp 2.7.5, Moonlight 2.16.0 and Sawmill 1.5.3 are working together in my modpack. If I update Moonlight beyond that, it stops working (and EveryComp 2.7.6 needs Moonlight to also be updated, so by extension that also does not work).

@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 13, 2024

It will take some time to find the bug and fix it. I'll check out the crash-report

EDIT:
Oh, something is wrong with Regions Unexplored Module, i'll need to look in it

@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 13, 2024

@Gamemassa Can you tell me which wood mod is it that caused the Minecraft to crash with EveryComp and Regions Unexplored?

I'm trying to find out which leavesType has no WoodType.

EDIT:
Update EveryComp to v2.8.0 but first backup your world. It has major changes and some bug-fixing

Let me know if that fix the problem or not.

@Gamemassa
Copy link
Author

I updated EveryComp to 2.8.0 and I'm still getting a crash on startup.

Crash Report:
https://mclo.gs/6T1Tavg

Latest.log
https://mclo.gs/OGTLeS1

@Xelbayria
Copy link
Collaborator

alright, i need the wood mod to find out what's going on

@MehVahdJukaar
Copy link
Owner

Seems regions unexplored branch blocks aren't checking if a leaf type has a log block

@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 15, 2024

Seems regions unexplored branch blocks aren't checking if a leaf type has a log block

I know. That's why i want to investigate to find out what's going on

@Gamemassa
Copy link
Author

Seems regions unexplored branch blocks aren't checking if a leaf type has a log block

Any idea which leaf type in particular?

@Xelbayria
Copy link
Collaborator

Forgot to close this. It wasn't leaf Type. The block required 2 things: a log and a sapling.

it was looking at the list via Leaf for wood Types but the list was empty.

@Xelbayria
Copy link
Collaborator

FIXED in v2.8.1

@Poopooracoocoo
Copy link

Seems to be fixed by commit 91d5ed8

@Xelbayria
Copy link
Collaborator

yup. the file, RegionsUnexploredModule.java. that will explain what was the cause.

@Gamemassa
Copy link
Author

Gamemassa commented Dec 21, 2024

Yeah, this seems to be fixed, though I am now getting this error message from Roughly Enough Items, which I have reported in their GitHub (and inb4 anyone asks, yes, I also made a new SP world and got the same error message, so it's not just that my old SP world broke).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants