New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于SSLWhiteList机制的小建议 #84

Open

hatsune-miku opened this issue Aug 21, 2021 · 0 comments

hatsune-miku commented Aug 21, 2021

您好，读代码看到了您写的SSLWhiteList机制，对握手失败的连接，会直接加入白名单、不再走Intercept，但是开发者对此的感知不大。

这就出现了一个尴尬的情况，明明证书是不对的，但是页面却能正常打开，并且不走onResponseInject相关回调，我误以为是兼容性问题导致NetBare不生效，差点因此错过这么好的一套框架

因此建议SSLWhiteList可以默认关闭，让握手失败的错误及时暴露出来，个人感觉更好一点。感谢作者的工作！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment