reporting civicrm#12 hack - support financial type custom fields on contribution reports

Author: MegaphoneJon

CRM/Core/BAO/CustomQuery.php

@@ -117,6 +117,7 @@ public function getFields() {
     'Address' => 'civicrm_address',
     'Campaign' => 'civicrm_campaign',
     'Survey' => 'civicrm_survey',
+    'FinancialType' => 'civicrm_financial_type',
   ];
 
   /**

CRM/Report/Form/Contribute/Detail.php

@@ -26,6 +26,7 @@ class CRM_Report_Form_Contribute_Detail extends CRM_Report_Form {
     'Contact',
     'Individual',
     'Contribution',
+    'FinancialType',
   ];
 
   protected $groupConcatTested = TRUE;

CRM/Report/Form/Contribute/SoftCredit.php

@@ -32,6 +32,7 @@ class CRM_Report_Form_Contribute_SoftCredit extends CRM_Report_Form {
     'Contact',
     'Individual',
     'Contribution',
+    'FinancialType',
   ];
 
   public $_drilldownReport = ['contribute/detail' => 'Link to Detail Report'];

CRM/Report/Form/Contribute/Summary.php

@@ -21,7 +21,7 @@ class CRM_Report_Form_Contribute_Summary extends CRM_Report_Form {
     'barChart' => 'Bar Chart',
     'pieChart' => 'Pie Chart',
   ];
-  protected $_customGroupExtends = ['Contribution', 'Contact', 'Individual'];
+  protected $_customGroupExtends = ['Contribution', 'Contact', 'Individual', 'FinancialType'];
   protected $_customGroupGroupBy = TRUE;
 
   public $_drilldownReport = ['contribute/detail' => 'Link to Detail Report'];

api/v3/utils.php

@@ -1315,7 +1315,7 @@ function _civicrm_api3_basic_create($bao_name, &$params, $entity = NULL) {
   else {
     // If we have custom fields the BAO may have taken care of it or we may have to.
     // $extendsMap provides a pretty good hard-coded list of BAOs that take care of the custom data.
-    if (isset($params['custom']) && empty(CRM_Core_BAO_CustomQuery::$extendsMap[$entity])) {
+    if (isset($params['custom']) && (empty(CRM_Core_BAO_CustomQuery::$extendsMap[$entity]) || $entity == 'FinancialType')) {
       CRM_Core_BAO_CustomValueTable::store($params['custom'], CRM_Core_DAO_AllCoreTables::getTableForClass(CRM_Core_DAO_AllCoreTables::getFullName($entity)), $bao->id);
     }
     $values = [];