From 4ff8484c186773faa825603faad690e170e7a8d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Tesa=C5=99?= <33880579+tesar-tech@users.noreply.github.com> Date: Mon, 17 Feb 2025 11:10:57 +0100 Subject: [PATCH] Devops: fix action for ubuntu-latest and invariant culture in tests (#5974) * adds invariant culture to date string. Avoiding the "seemingly same date strings fail the test ". * Formating --------- Co-authored-by: Mladen Macanovic --- .github/workflows/blazorise-ci-basic.yml | 2 +- .../DataGrid/Utils/FunctionCompilerTests.cs | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/blazorise-ci-basic.yml b/.github/workflows/blazorise-ci-basic.yml index 39db211edb..d2d8222497 100644 --- a/.github/workflows/blazorise-ci-basic.yml +++ b/.github/workflows/blazorise-ci-basic.yml @@ -5,7 +5,7 @@ on: [push] jobs: build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 diff --git a/Tests/Blazorise.Tests/DataGrid/Utils/FunctionCompilerTests.cs b/Tests/Blazorise.Tests/DataGrid/Utils/FunctionCompilerTests.cs index 6acf3fa803..9cc9dc95b4 100644 --- a/Tests/Blazorise.Tests/DataGrid/Utils/FunctionCompilerTests.cs +++ b/Tests/Blazorise.Tests/DataGrid/Utils/FunctionCompilerTests.cs @@ -25,8 +25,13 @@ public void ValueGetter_ReturnsCorrectPropertyOrField_DefaultValue( string field { var test = new Test(); var valueGetter = FunctionCompiler.CreateValueGetter( field ); + var value = valueGetter( test ); - Assert.Equal( expected, valueGetter( test )?.ToString() ); + Assert.Equal( expected, value switch + { + DateTime dt => dt.ToString( "M/d/yyyy h:mm:ss tt", CultureInfo.InvariantCulture ), + _ => value?.ToString() + } ); } [Theory] @@ -47,8 +52,13 @@ public void ValueGetter_ReturnsCorrectPropertyOrField_ActualValue( string field, { var test = GetTest(); var valueGetter = FunctionCompiler.CreateValueGetter( field ); + var value = valueGetter( test ); - Assert.Equal( expected, valueGetter( test )?.ToString() ); + Assert.Equal( expected, value switch + { + DateTime dt => dt.ToString( "M/d/yyyy h:mm:ss tt", CultureInfo.InvariantCulture ), + _ => value?.ToString() + } ); } public FunctionCompilerTests()