Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading game blocking main thread #233

Open
pavanvo opened this issue Aug 3, 2022 · 3 comments · May be fixed by #240
Open

Loading game blocking main thread #233

pavanvo opened this issue Aug 3, 2022 · 3 comments · May be fixed by #240

Comments

@pavanvo
Copy link

pavanvo commented Aug 3, 2022

Step to reproduce:

  1. Run the custom game
  2. Save the game a few times
  3. Exit, back to maim menu
  4. Try to switch between saves

This loading from .xml should run async

@Rampoina
Copy link
Contributor

Rampoina commented Aug 3, 2022

It's quite fast here but just to be sure:

  • you're describing the small pause it does when you click on a saved game on the loading menu (you can see the background rain stopping for example)

@pavanvo
Copy link
Author

pavanvo commented Aug 3, 2022

yep) rain stopping

@pavanvo pavanvo linked a pull request Aug 7, 2022 that will close this issue
@Rampoina
Copy link
Contributor

Rampoina commented Aug 11, 2022

I spotted a few more places where this could be used:

  • going into a custom game
  • changing the faction on the custom game screen
  • loading a scenario on the scenario screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants