Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No FFV1 implementation checks count in XML #198

Open
kieranjol opened this issue Aug 7, 2017 · 7 comments
Open

No FFV1 implementation checks count in XML #198

kieranjol opened this issue Aug 7, 2017 · 7 comments

Comments

@kieranjol
Copy link

I'm on Ubunutu 16.04 with the daily snapshot of mediaconch and libmediainfo.
I only just noticed that while several Matroska implementation checks run in the GUI and CLI, no FFV1 checks run:

<implementationChecks checks_run="0" fail_count="0" pass_count="0">
      <name>MediaConch FFV1 Implementation Checker</name>

Here's an example file where this happens: https://drive.google.com/file/d/0ByvCvU9YVB09WTNSQ2ZEdXk2YXM/view?usp=sharing

I'm assuming that something is wrong with my command/environment?

@kieranjol
Copy link
Author

@dericed
Copy link
Contributor

dericed commented Aug 7, 2017

hmmm, can you retry with --force

@kieranjol
Copy link
Author

kieranjol commented Aug 7, 2017 via email

@kieranjol
Copy link
Author

I replicated on Windows 10 with today's snapshot.

I think this could also be related, though it might be a seperate issue:
mediaconch -mi filename
returns nothing.I installed the latest libmediainfo as well on Win10 and Ubuntu,

@JeromeMartinez
Copy link
Member

We use a different method for checking FFV1 bitstream because the one we use for MKV is too slow with so much data as it is in FFV1 (thousands of frames and we need to parse the whole frame content).
As a result, the XML sees only fails for the moment.

We definitely need to change the output, showing also the count of succeeded tests instead of "0".

@JeromeMartinez JeromeMartinez changed the title No FFV1 implementation checks running No FFV1 implementation checks count in XML Aug 8, 2017
@kieranjol
Copy link
Author

Hi Jerome, that would be ideal. My usage of Mediaconch involves looking at those summary judgements using an XML parser and determining if the validation=PASS/FAIL. It's good to know that fail_count=0 means that analysis was carried out, but it would be ideal to know that n checks were carried out and all passed, even if each one isn't documented in XML elements.

@JeromeMartinez
Copy link
Member

ok. we need to do:

  • @dericed, we need to agree about where you find this value in the trace, then adapt the XSL for peeking this value
  • we also need to be sure about the meaning of this value: for Matroska tests, it is easy, there is only 1 Matroska part, but for FFV1 we have several frames. Maybe we need 2 numbers: the count of frames parsed (e.g. "90000" for a 1-hour PAL file) + the total count of tests (e.g. "1800000" for a 1-hour PAL file and 20 tests per frame). Comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants