Users crashing due to the program failing to save images

[McSib]

This a current bug that's been floating around for a while now, and is happening with a few users. What seems to be happening is the downloading starts, and then while downloading, the program crashes when trying to save the image. This issue will be a task list of both issues that discuss this and will be the main update hub for sources of information around it.

• A downloaded image was unable to be saved... #59
• Failed to save image - System cannot find the path specified. #58

[McSib]

From looking into #58, I'm wondering if the issue is directly tied to an invalid character of some kind. We have code for filtering invalid characters in folder/file names.

mod.rs#L121...L130

    /// Removes invalid characters from directory name.
    fn remove_invalid_chars(&self, dir_name: &str) -> String {
        dir_name
            .chars()
            .map(|e| match e {
                '?' | ':' | '*' | '<' | '>' | '\"' | '|' => '_',
                _ => e,
            })
            .collect()
    }

I suggest this because it looks like there is an empty space at the end of the folder name in the log.

15:51:30 [TRACE] (1) e621_downloader::e621: [src\e621\mod.rs:171] Collection Name:            "freckles_(artist) "
15:51:30 [TRACE] (1) e621_downloader::e621: [src\e621\mod.rs:172] Collection Category:        "General Searches"
15:51:30 [TRACE] (1) e621_downloader::e621: [src\e621\mod.rs:173] Collection Post Length:     "2490"
15:51:30 [TRACE] (1) e621_downloader::e621: [src\e621\mod.rs:177] Static file path for this collection: "downloads/General Searches\freckles_(artist) "

It's possible there could be some undefined behavior because of it.

[McSib]

This bug has been marked as fixed. It was curious, but the moment I saw a space at the end of the collection name, I had a gut feeling about what might've been happening.

The recent commit and branch merge on the develop branch shows the issue more clearly.

The program had a collection name (which turns into the folder name) with a space at the end. This is an invalid name for folders, and the system will ignore creating it.