Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ASN1 functions in a build with RSA_C #9041

Closed
valeriosetti opened this issue Apr 19, 2024 · 0 comments · Fixed by #9035
Closed

Missing ASN1 functions in a build with RSA_C #9041

valeriosetti opened this issue Apr 19, 2024 · 0 comments · Fixed by #9035
Assignees
Labels
bug priority-high High priority - will be reviewed soon

Comments

@valeriosetti
Copy link
Contributor

Summary

RSA module depends on ASN1 functions for parsing and writing public and private keys. However:

  • there is no check that MBEDTLS_ASN1_[WRITE|PARSE]_C are enabled in check_config.h, or
  • MBEDTLS_ASN1_[WRITE|PARSE]_C are not automatically-enabled when MBEDTLS_RSA_C is enabled.

The result is that a build where RSA is enabled while ASN1 is disabled will not build at all due to missing symbols at link time.

The goal of this issue is to implement one of the two options above (preferably the 2nd one since it's more backward compatible).

System information

Mbed TLS version (number or commit id): 3.6.0
Operating system and version: not relevant
Configuration (if not default, please attach mbedtls_config.h): default without ASN1 (and connected dependencies on check_config.h such as ECDSA and PK)
Compiler and options (if you used a pre-built binary, please indicate how you obtained it): n/a
Additional environment information: n/a

@valeriosetti valeriosetti added bug priority-high High priority - will be reviewed soon labels Apr 19, 2024
@valeriosetti valeriosetti self-assigned this Apr 19, 2024
@mpg mpg closed this as completed in #9035 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority-high High priority - will be reviewed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant