Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile errors when enabling TLS 1.3 without session tickets #6395

Closed
cruxic opened this issue Oct 6, 2022 · 2 comments · Fixed by #6955
Closed

compile errors when enabling TLS 1.3 without session tickets #6395

cruxic opened this issue Oct 6, 2022 · 2 comments · Fixed by #6955
Assignees
Labels
bug component-tls size-s Estimated task size: small (~2d)

Comments

@cruxic
Copy link

cruxic commented Oct 6, 2022

Compile fails on development branch (gcc 11.2.0 on Ubuntu 22.04) if you make these two changes to mbedtls_config.h:

Uncomment:
#define MBEDTLS_SSL_PROTO_TLS1_3
Comment-out:
//#define MBEDTLS_SSL_SESSION_TICKETS

The first compiler error is trivial to fix, just add a missing const to a function argument.

ssl_tls.c:3181:50: error: passing argument 2 of ‘ssl_tls13_session_load’ discards ‘const’ qualifier from pointer target type

However, after fixing this you will get many other errors. I'm trying to configure the library for TLS 1.2 and 1.3 support without session ticket support (reduce attack surface).

@ronald-cron-arm ronald-cron-arm added the size-s Estimated task size: small (~2d) label Oct 12, 2022
@yuhaoth
Copy link
Contributor

yuhaoth commented Oct 21, 2022

I think we should add components without MBEDTLS_SSL_SESSION_TICKETS in all.sh.

@yuhaoth
Copy link
Contributor

yuhaoth commented Oct 26, 2022

See #6411.

  • Add test configuration without MBEDTLS_SSL_SESSION_TICKETS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component-tls size-s Estimated task size: small (~2d)
Projects
Status: [3.6] TLS 1.3 misc for LTS
Development

Successfully merging a pull request may close this issue.

4 participants