Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make windowsBuild externally accessible #32

Open
russellbanks opened this issue Feb 4, 2023 · 1 comment
Open

Make windowsBuild externally accessible #32

russellbanks opened this issue Feb 4, 2023 · 1 comment

Comments

@russellbanks
Copy link

As frameStyle's values are only applicable on Windows 11 and above, it would be helpful to expose the windowsBuild variable so that relevant settings can only be shown to the user if those features are supported for their Windows version.

Currently, in my application, I copy over the relevant code. It would be easier if this was exposed in the library by being made public or exposed through a getter function.

Use case (the options are only shown on >= Windows 11):

java_spGVxcF7Er

@MSDarwish2000
Copy link
Member

Thank you for your suggestion. I think adding isSupported to each effect and adding getSupportedEffects() or similar approaches would be better, easier to use, and support other platforms (when added). I'll work on this once I have time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants