From 7234e6ae8abaf3ecd44936a4a8454e2313e18b33 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Tue, 6 Mar 2018 11:42:21 +0530 Subject: [PATCH] test: rename test-regress-GH-4015 Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil --- ...st-regress-GH-4015.js => test-regress-fs-stat_sync.js} | 8 ++++++++ 1 file changed, 8 insertions(+) rename test/sequential/{test-regress-GH-4015.js => test-regress-fs-stat_sync.js} (80%) diff --git a/test/sequential/test-regress-GH-4015.js b/test/sequential/test-regress-fs-stat_sync.js similarity index 80% rename from test/sequential/test-regress-GH-4015.js rename to test/sequential/test-regress-fs-stat_sync.js index cac20c7948ae2f..c770b6b1560785 100644 --- a/test/sequential/test-regress-GH-4015.js +++ b/test/sequential/test-regress-fs-stat_sync.js @@ -22,6 +22,14 @@ 'use strict'; require('../common'); const { fixturesDir } = require('../common/fixtures'); + +// Check that the calls to Integer::New() and Date::New() succeed and bail out +// if they don't. +// V8 returns an empty handle on stack overflow. Trying to set the empty handle +// as a property on an object results in a NULL pointer dereference in release +// builds and an assert in debug builds. +// https://github.com/nodejs/node-v0.x-archive/issues/4015 + const assert = require('assert'); const { exec } = require('child_process');