Skip to content

Commit 45ecbba

Browse files
MylesBorinsMayaLekova
authored andcommitted
events: preset usingDomains to false
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: nodejs#17403 (comment) PR-URL: nodejs#18944 Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent d57fcec commit 45ecbba

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

lib/events.js

+2
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ module.exports = EventEmitter;
3131
// Backwards-compat with node 0.10.x
3232
EventEmitter.EventEmitter = EventEmitter;
3333

34+
EventEmitter.usingDomains = false;
35+
3436
EventEmitter.prototype._events = undefined;
3537
EventEmitter.prototype._eventsCount = 0;
3638
EventEmitter.prototype._maxListeners = undefined;

test/parallel/test-event-emitter-subclass.js

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ function MyEE(cb) {
3636

3737
const myee = new MyEE(common.mustCall());
3838

39+
myee.hasOwnProperty('usingDomains');
3940

4041
util.inherits(ErrorEE, EventEmitter);
4142
function ErrorEE() {

0 commit comments

Comments
 (0)