Skip to content

Commit 23f87ad

Browse files
committed
fix: gmtime->localtime
1 parent bd605a5 commit 23f87ad

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

google/cloud/spanner_dbapi/types.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ def Timestamp(year, month, day, hour, minute, second):
2525

2626

2727
def DateFromTicks(ticks):
28-
return Date(*time.gmtime(ticks)[:3])
28+
return Date(*time.localtime(ticks)[:3])
2929

3030

3131
def TimeFromTicks(ticks):
32-
return Time(*time.gmtime(ticks)[3:6])
32+
return Time(*time.localtime(ticks)[3:6])
3333

3434

3535
def TimestampFromTicks(ticks):
36-
return Timestamp(*time.gmtime(ticks)[:6])
36+
return Timestamp(*time.localtime(ticks)[:6])
3737

3838

3939
def Binary(string):

tests/spanner_dbapi/test_types.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
)
1919
from google.cloud.spanner_dbapi.utils import PeekIterator
2020

21+
utcOffset = time.timezone # offset for current timezone
22+
2123
class TypesTests(TestCase):
2224
def test_Date(self):
2325
actual = Date(2019, 11, 3)
@@ -37,7 +39,7 @@ def test_Timestamp(self):
3739
def test_DateFromTicks(self):
3840
epochTicks = 1572822862 # Sun Nov 03 23:14:22 2019 GMT
3941

40-
actual = DateFromTicks(epochTicks)
42+
actual = DateFromTicks(epochTicks + utcOffset)
4143
expected = datetime.date(2019, 11, 3)
4244

4345
self.assertTrue(
@@ -47,7 +49,7 @@ def test_DateFromTicks(self):
4749
def test_TimeFromTicks(self):
4850
epochTicks = 1572822862 # Sun Nov 03 23:14:22 2019 GMT
4951

50-
actual = TimeFromTicks(epochTicks)
52+
actual = TimeFromTicks(epochTicks + utcOffset)
5153
expected = datetime.time(23, 14, 22)
5254

5355
self.assertTrue(
@@ -57,7 +59,7 @@ def test_TimeFromTicks(self):
5759
def test_TimestampFromTicks(self):
5860
epochTicks = 1572822862 # Sun Nov 03 23:14:22 2019 GMT
5961

60-
actual = TimestampFromTicks(epochTicks)
62+
actual = TimestampFromTicks(epochTicks + utcOffset)
6163
expected = datetime.datetime(2019, 11, 3, 23, 14, 22)
6264

6365
self.assertTrue(

0 commit comments

Comments
 (0)