Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify interface name linting #123

Closed
Maxim-Mazurok opened this issue Apr 8, 2020 · 4 comments
Closed

Verify interface name linting #123

Maxim-Mazurok opened this issue Apr 8, 2020 · 4 comments
Assignees
@Maxim-Mazurok
Labels
enhancement New feature or request

Comments

@Maxim-Mazurok
Copy link
Owner

Do we have to suppress linter rules for interface Iexample or only for interface IExample?
@Maxim-Mazurok Maxim-Mazurok added the enhancement New feature or request label Apr 8, 2020
@Maxim-Mazurok
Copy link
Owner Author

https://github.com/palantir/tslint/blob/a66f3b3430b4d3f03ff93fcef94609b88809d4e1/test/rules/interface-name/never-prefix/test.ts.lint

@Maxim-Mazurok Maxim-Mazurok self-assigned this Apr 22, 2020
@Maxim-Mazurok
Copy link
Owner Author

Maxim-Mazurok commented Apr 22, 2020 •
edited
Loading

We should be able to remove

google-api-typings-generator/src/app.ts

Lines 165 to 168 in 3d2e0c6

if (name && name[0] && name[0] === 'I') {
// workaround for cases like `IPAllocationPolicy`
ignoreRules.push('interface-name');
}

completely once microsoft/dtslint#285 get's merged and microsoft/dtslint#284 get's fixed

@Maxim-Mazurok
Copy link
Owner Author

Examples:
I18n
I18nLanguage
ITunesConnectAnalytics
IPAllocationPolicy

@Maxim-Mazurok
Copy link
Owner Author

Closed by #390 there's not much we can do right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maxim-Mazurok Maxim-Mazurok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Maxim-Mazurok