Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden concurrency service on restart #95

Open
maxfischer2781 opened this issue Sep 16, 2021 · 0 comments
Open

Harden concurrency service on restart #95

maxfischer2781 opened this issue Sep 16, 2021 · 0 comments
Labels
subject: code health subject: daemon Issues affecting the daemon framework

Comments

@maxfischer2781
Copy link
Member

The concurrency service of cobald has been written with just a single run – as a demon – in mind. However, unittests will rerun or recreate the service several times.

Spurious test failures via PyPy were observed on #94. Since PyPy uses a different garbage collection strategy with higher latency, this indicates the concurrency service has implicit dependency on prompt cleanup.

This is not an issue in production, but hints at the code not being robust. The service should be reviewed and possibly rewritten to have proper, explicit lifetime.

@maxfischer2781 maxfischer2781 added subject: daemon Issues affecting the daemon framework subject: code health labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subject: code health subject: daemon Issues affecting the daemon framework
Projects
None yet
Development

No branches or pull requests

1 participant