CLN: GH29547 change string formatting with f-strings - revert useless changes

Author: Matteo Felici

pandas/tests/io/test_html.py

@@ -507,8 +507,7 @@ def test_tfoot_read(self):
         Make sure that read_html reads tfoot, containing td or th.
         Ignores empty tfoot
         """
-        data_template = (
-            lambda footer: f"""<table>
+        data_template = """<table>
             <thead>
                 <tr>
                     <th>A</th>
@@ -525,16 +524,15 @@ def test_tfoot_read(self):
                 {footer}
             </tfoot>
         </table>"""
-        )
 
         expected1 = DataFrame(data=[["bodyA", "bodyB"]], columns=["A", "B"])
 
         expected2 = DataFrame(
             data=[["bodyA", "bodyB"], ["footA", "footB"]], columns=["A", "B"]
         )
 
-        data1 = data_template(footer="")
-        data2 = data_template(footer="<tr><td>footA</td><th>footB</th></tr>")
+        data1 = data_template.format(footer="")
+        data2 = data_template.format(footer="<tr><td>footA</td><th>footB</th></tr>")
 
         result1 = self.read_html(data1)[0]
         result2 = self.read_html(data2)[0]

pandas/tests/reshape/test_melt.py

@@ -313,30 +313,32 @@ def test_melt_missing_columns_raises(self):
         df = pd.DataFrame(np.random.randn(5, 4), columns=list("abcd"))
 
         # Try to melt with missing `value_vars` column name
-        msg = (
-            lambda Var, Col: f"The following '{Var}' are not present in "
-            f"the DataFrame: {Col}"
-        )
-        with pytest.raises(KeyError, match=msg(Var="value_vars", Col="\\['C'\\]")):
+        msg = "The following '{Var}' are not present in the DataFrame: {Col}"
+        with pytest.raises(
+            KeyError, match=msg.format(Var="value_vars", Col="\\['C'\\]")
+        ):
             df.melt(["a", "b"], ["C", "d"])
 
         # Try to melt with missing `id_vars` column name
-        with pytest.raises(KeyError, match=msg(Var="id_vars", Col="\\['A'\\]")):
+        with pytest.raises(KeyError, match=msg.format(Var="id_vars", Col="\\['A'\\]")):
             df.melt(["A", "b"], ["c", "d"])
 
         # Multiple missing
         with pytest.raises(
-            KeyError, match=msg(Var="id_vars", Col="\\['not_here', 'or_there'\\]"),
+            KeyError,
+            match=msg.format(Var="id_vars", Col="\\['not_here', 'or_there'\\]"),
         ):
             df.melt(["a", "b", "not_here", "or_there"], ["c", "d"])
 
         # Multiindex melt fails if column is missing from multilevel melt
         multi = df.copy()
         multi.columns = [list("ABCD"), list("abcd")]
-        with pytest.raises(KeyError, match=msg(Var="id_vars", Col="\\['E'\\]")):
+        with pytest.raises(KeyError, match=msg.format(Var="id_vars", Col="\\['E'\\]")):
             multi.melt([("E", "a")], [("B", "b")])
         # Multiindex fails if column is missing from single level melt
-        with pytest.raises(KeyError, match=msg(Var="value_vars", Col="\\['F'\\]")):
+        with pytest.raises(
+            KeyError, match=msg.format(Var="value_vars", Col="\\['F'\\]")
+        ):
             multi.melt(["A"], ["F"], col_level=0)
 
     def test_melt_mixed_int_str_id_vars(self):

pandas/tests/scalar/timedelta/test_timedelta.py

@@ -83,12 +83,12 @@ def check(value):
         assert rng.microseconds == 0
         assert rng.nanoseconds == 0
 
-        msg = lambda x: f"'Timedelta' object has no attribute '{x}'"
-        with pytest.raises(AttributeError, match=msg("hours")):
+        msg = "'Timedelta' object has no attribute '{}'"
+        with pytest.raises(AttributeError, match=msg.format("hours")):
             rng.hours
-        with pytest.raises(AttributeError, match=msg("minutes")):
+        with pytest.raises(AttributeError, match=msg.format("minutes")):
             rng.minutes
-        with pytest.raises(AttributeError, match=msg("milliseconds")):
+        with pytest.raises(AttributeError, match=msg.format("milliseconds")):
             rng.milliseconds
 
         # GH 10050
@@ -109,12 +109,12 @@ def check(value):
         assert rng.seconds == 10 * 3600 + 11 * 60 + 12
         assert rng.microseconds == 100 * 1000 + 123
         assert rng.nanoseconds == 456
-        msg = lambda x: f"'Timedelta' object has no attribute '{x}'"
-        with pytest.raises(AttributeError, match=msg("hours")):
+        msg = "'Timedelta' object has no attribute '{}'"
+        with pytest.raises(AttributeError, match=msg.format("hours")):
             rng.hours
-        with pytest.raises(AttributeError, match=msg("minutes")):
+        with pytest.raises(AttributeError, match=msg.format("minutes")):
             rng.minutes
-        with pytest.raises(AttributeError, match=msg("milliseconds")):
+        with pytest.raises(AttributeError, match=msg.format("milliseconds")):
             rng.milliseconds
 
         # components