Skip to content

Put test_rules_patterns tests where they belong #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2022
Merged

Put test_rules_patterns tests where they belong #612

merged 1 commit into from
Nov 12, 2022

Conversation

@rocky
Copy link
Member

@rocky rocky commented Nov 12, 2022 •
edited by gitpod-io bot
Loading

Move tests into more specific tests for the module that the tests are in.

mmatera
mmatera approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera
Copy link
Contributor

mmatera commented Nov 12, 2022

Just one comment. The test are about how Pattern which is a class in mathics.core behaves over certain expressions, more than about how the mathics.builin.attributes module does. My guess is that the right place would be test.core.pattern.

@rocky
Copy link
Member Author

rocky commented Nov 12, 2022

Just one comment. The test are about how Pattern which is a class in mathics.core behaves over certain expressions, more than about how the mathics.builin.attributes module does. My guess is that the right place would be test.core.pattern.

Ok - I will make the change. But I am not exactly sure which function(s) you are referring to. Please be more specific. Or if you want, feel free to commit on top of this.

@rocky
Copy link
Member Author

rocky commented Nov 12, 2022

I encourage moving tests around further later as we see fit. This is just a start.

@rocky rocky merged commit cc92b6c into fix_one_identity Nov 12, 2022
@rocky rocky deleted the reduce-test_rules_patterns branch November 12, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmatera mmatera mmatera approved these changes

@TiagoCavalcante TiagoCavalcante Awaiting requested review from TiagoCavalcante

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rocky @mmatera