-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Array Containment Operator Mapping and pgcompat Issue #28044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix and additional test cases!
8b0b54f
to
00a6723
Compare
Nightly build for the re-enabled contains operator in the output-consistency framework: https://buildkite.com/materialize/nightly/builds/8366 |
This is a minimal repro which returns
I suspect this happens because the implementation is checking |
Nightly is still hitting this panic:
|
For some reason, the panic does not reproduce in a local build.
with
|
The failure in the nightly build occurs in the version-consistency build step. This build step compares the current version against its ancestor. In this case, the current version will be compared against the merge base, which is the commit from which this branch branched off. Since that earlier version contained the fault causing a panic, it is expected for this build to fail (it exercises the earlier version as well). => TLDR: Failure of version-consistency is expected. Good from QA side. |
closes #28035 --------- Co-authored-by: Rainer Niedermayr <[email protected]>
closes #28035