Native Wayland Support

[nyabinary]

This should be simple since it's just passing a flag to Electron --ozone-platform-hint
electron/electron#33810
electron/electron#34937
Support for this flag was added last year.

[Mastermindzh]

Hey @nyabinary,

Not a problem!
Can you confirm things work as expected? Are there any bugs if you enable the flag?

There are a couple of big things I want to do in the coming month or so:

• Look at theming again (some errors in my theme files)
• Implement plugins (requested)
• Implement flag management (this + some other questions)

If this flag results in little/no bugs it could move upwards in priority (though the list is unordered atm)

Thanks for the help anyway!~

[nyabinary]

@Mastermindzh
tidal-hifi --enable-features=UseOzonePlatform --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations
It works fine, with no bugs in my case. I checked settings, checked the about page, went to every menu in Tidal, and played a couple of songs, You need to enable Wayland window decorations to get the title bar!

[Mastermindzh]

I'll just load up Gnome next to my i3 instance and test from there when I add it.
Glad to hear everything seems to work, that means this is quite minor.

I recommend you change your .desktop file to include the extra parameters for now and I'll see when I can add a "wayland support" flag :)

[nyabinary]

Yeah, I checked everything, and no bugs only thing is "Manage Subscription" pop-up window is broken, but it's also broken in X11 as well. Updating to Electron 25 would be good as well (Just in general)

[nyabinary]

I just realized this solved the weird bug I had when in GNOME. The app didn't show up in the taskbar as, well.

[Mastermindzh]

Ah... so Wayland also does something for the icons in the (now wayland backed...) taskbar. Gotcha.

Idk what you're talking about with manage subscriptions (I am on the highest tier so I have no need to go there...).
Can you tell me what you encounter where? Might be an additional bug that we can solve along the way somewhere 😄

Thanks for the detailed responses! Very helpful!

[nyabinary]

Going over here and clicking managing subscription(I'm also in the highest subscription tier, if that matters) pops up an additional window on both X11 and Wayland. Still, both windows show the fixed menu bar and title bar(even if you have the fixed menu bar enabled or disabled), and the body of the window itself is blank.

[nyabinary]

Another thing to note, when I use the X11 version, this pops up in the terminal (the last line specifically)

[Mastermindzh]

@nyabinary Chrome rendering errors showing up are... normal 😄.

Also... I just fixed flag parsing... (was messed up..) and also added Wayland support:

Will be available in the next release that will be released later this week 😄