Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting NotAllowError message when identifying errors in the browser #352

Closed
MasterKale opened this issue Feb 8, 2023 · 1 comment · Fixed by #353
Closed

Stop overwriting NotAllowError message when identifying errors in the browser #352

MasterKale opened this issue Feb 8, 2023 · 1 comment · Fixed by #353

Comments

@MasterKale
Copy link
Owner

Twice now my error identification logic has overwritten a NotAllowedError message with one that is spec-accurate but completely obfuscates the real issue that becomes obvious if one could read it:

In both instances I overwrote these messages with "User clicked cancel, or the authentication ceremony timed out" because it was the second of two possible reasons the error would be raised. Clearly platforms are using this error type to report platform-specific errors, though, and so I should stop overwriting these messages to make it easier for RP's to diagnose issues that aren't library-specific.

@MasterKale
Copy link
Owner Author

This is now available in @simplewebauthn/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant