fix: values in compile_alter_sql

[Kyrela]

fix #884

note that the change line 343 doesn't change anything as the function isn't used, but could be useful if this behavior is changed.

Works with the example given in the issue.

[josephmancuso]

just needs a test

[Kyrela]

Should I edit BaseConnection.py to remove the additional blank line?

[josephmancuso]

Should I edit BaseConnection.py to remove the additional blank line?

idk what youre talking about but sure i think

[Kyrela]

I'm talking about the lint results.

No link with my PR, but as the linter is triggered by it, I guess I could fix it?

[josephmancuso]

oh, yes please

[josephmancuso]

adding tests are pretty simple if you could add one for enum

[Kyrela]

adding tests are pretty simple if you could add one for enum

Oh, sure, was thinking about it.

[Kyrela]

Not sure about the quality of my tests tbh, but I added a test for the bug referenced in issue #885 and tests for changing an enum or adding it in a new table. If these are good, should I add similar ones for the other sql dialects?

[josephmancuso]

Not sure about the quality of my tests tbh, but I added a test for the bug referenced in issue #885 and tests for changing an enum or adding it in a new table. If these are good, should I add similar ones for the other sql dialects?

yes please, code looks good 👍

[Kyrela]

Hello, any update?