Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed UUID PK Mixin not creating primary key on bulk create #845

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Fixed UUID PK Mixin not creating primary key on bulk create #845

merged 1 commit into from
Sep 30, 2023

Conversation

circulon
Copy link
Contributor

This PR fixes the issue where bulk create would not create a primary key attribute if the UUIDPrimaryKeyMixin was used on the Model

@circulon circulon changed the title Fixed UUID PK Mixin not creating primary key Fixed UUID PK Mixin not creating primary key on bulk create Mar 11, 2023
stoutput
stoutput approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@stoutput stoutput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for this. This LGTM. @josephmancuso?

@josephmancuso josephmancuso merged commit 1edbb44 into MasoniteFramework:2.0 Sep 30, 2023
@josephmancuso
Copy link
Member

LGTM too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

@stoutput stoutput stoutput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@circulon @josephmancuso @stoutput